Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links #5492

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Fix links #5492

merged 4 commits into from
Oct 29, 2024

Conversation

anthony0030
Copy link
Contributor

  1. Adds sript to find broken links
  2. Fixes links
cd uppy
./bin/check-broken-links.sh

The broken links will be written to uppy/link_check_log.txt

This script has been tested on Mac OS only.

$ cd uppy
$ ./bin/check-broken-links.sh

The broken links will be written to uppy/link_check_log.txt

This script has been tested on Mac OS only.
Copy link
Contributor

Diff output files
No diff

The following build files have been modified and might affect the actual diff:

bin/check-broken-links.sh

Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate you taking the time to fix all the links but I don't think I want to take on this script. We already have private/remark-lint-uppy which with a one line addition we have the same functionality with https://github.com/remarkjs/remark-lint-no-dead-urls

I'm also okay with merging all the fixes if you remove the script

@anthony0030
Copy link
Contributor Author

Hi @Murderlon, I removed the script from the pull request.

Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@Murderlon Murderlon merged commit 71a6fcd into transloadit:main Oct 29, 2024
5 checks passed
@anthony0030 anthony0030 deleted the fix-links branch October 29, 2024 17:22
github-actions bot added a commit that referenced this pull request Oct 31, 2024
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/aws-s3              |   4.1.1 | @uppy/provider-views      |   4.0.2 |
| @uppy/box                 |   3.1.1 | @uppy/react               |   4.0.3 |
| @uppy/companion           |   5.1.3 | @uppy/react-native        |   0.6.1 |
| @uppy/companion-client    |   4.1.1 | @uppy/redux-dev-tools     |   4.0.1 |
| @uppy/core                |   4.2.3 | @uppy/screen-capture      |   4.1.1 |
| @uppy/dashboard           |   4.1.2 | @uppy/status-bar          |   4.0.4 |
| @uppy/drag-drop           |   4.0.4 | @uppy/store-default       |   4.1.1 |
| @uppy/dropbox             |   4.1.1 | @uppy/store-redux         |   4.0.1 |
| @uppy/facebook            |   4.1.1 | @uppy/svelte              |   4.1.1 |
| @uppy/file-input          |   4.0.3 | @uppy/thumbnail-generator |   4.0.1 |
| @uppy/form                |   4.0.1 | @uppy/transloadit         |   4.1.3 |
| @uppy/golden-retriever    |   4.0.1 | @uppy/tus                 |   4.1.3 |
| @uppy/google-drive        |   4.1.1 | @uppy/unsplash            |   4.1.1 |
| @uppy/google-photos       |   0.3.1 | @uppy/url                 |   4.1.1 |
| @uppy/image-editor        |   3.2.0 | @uppy/utils               |   6.0.4 |
| @uppy/informer            |   4.1.1 | @uppy/vue                 |   2.0.2 |
| @uppy/instagram           |   4.1.1 | @uppy/webcam              |   4.0.2 |
| @uppy/locales             |   4.2.1 | @uppy/xhr-upload          |   4.2.2 |
| @uppy/onedrive            |   4.1.1 | @uppy/zoom                |   3.1.1 |
| @uppy/progress-bar        |   4.0.1 | uppy                      |   4.6.0 |

- @uppy/xhr-upload: fix stale file references in events (Merlijn Vos / #5499)
- @uppy/image-editor: upgrade cropperjs (Merlijn Vos / #5497)
- @uppy/aws-s3,@uppy/box,@uppy/companion-client,@uppy/core,@uppy/dashboard,@uppy/drag-drop,@uppy/dropbox,@uppy/facebook,@uppy/file-input,@uppy/form,@uppy/golden-retriever,@uppy/google-drive,@uppy/google-photos,@uppy/image-editor,@uppy/informer,@uppy/instagram,@uppy/locales,@uppy/onedrive,@uppy/progress-bar,@uppy/provider-views,@uppy/react-native,@uppy/react,@uppy/redux-dev-tools,@uppy/screen-capture,@uppy/status-bar,@uppy/store-default,@uppy/store-redux,@uppy/svelte,@uppy/thumbnail-generator,@uppy/transloadit,@uppy/tus,@uppy/unsplash,@uppy/url,@uppy/utils,@uppy/vue,@uppy/webcam,@uppy/xhr-upload,@uppy/zoom: Fix links (Anthony Veaudry / #5492)
- docs,@uppy/companion: disallow corsOrigins "*" (Mikael Finstad / #5496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants